On Monday 20 August 2012 16:27:19 Lucas Meneghel Rodrigues wrote: > On Fri, 2012-08-17 at 14:00 +0200, Plamen Dimitrov wrote: > > Dear autotest team, > > > > I made an lvm test that creates a basic image, takes snapshots from it, > > reverts and cleans up with the addition that it can create a volume group > > on top of the ramdisk for quicker read/write ops. Some things are still > > hardcoded but I can change this if the test could be of your interest. > > Thanks Plamen! We appreciate the contribution, certainly. I'd like to > make some comments on your code, so please: > > 1) Take into account the comments > 2) Create a patch using git against the autotest -next branch > 3) Send it using git send-email or a github pull request. Please read:
Thanks for the feedback! I will send an updated patch with your concerns addressed in a separate e-mail. It passed the autotest pylint wrapper and the autotest unittests suite. > 1st general comment: The auxiliary functions could be turned into a > library (although on a first pass it's good that they're internal to the > test, so the code can be refined a bit before a library comes out of > it). Good idea, I have prepared most of the test for modification to a utility library in case we decide to go for it in the future. Kind regards, Plamen _______________________________________________ Autotest-kernel mailing list [email protected] https://www.redhat.com/mailman/listinfo/autotest-kernel
