On 08/20/2012 06:18 AM, Yu Mingfei wrote:
On 10/08/12 22:46, Chris Evich wrote:
On 08/10/2012 05:46 AM, Yu Mingfei wrote:
Hi Chris,Lucas:

This patchset adds test for virt-edit.

virt-edit is a tool to edit a vm's disk directly.
It depends on package(libguestfs for linux and libguestfs-winsupport for
windows).

In this patchset, I add Chris' xml_utils.py to enough my patchs.^_^
And since XMLTreeFile has not been committed to master,I still use
XMLBase here,
you can change it as you need.>> Chris

And this patchset depends on libvirt_xml's vm_rename(), so I patch them
together.

BTW,I'm on my vacation nextweek, so forgive my answer's delay :-).

Yu Mingfei (4):
shared.xml_utils:add remove() to XMLBase.
virt.libvirt_xml:Add libvirt xml rename function.
virt.subtest.cfg.sample:Add configuration for virt-edit.
client.tests.libvirt:Add test for virt-edit.

client/shared/xml_utils.py | 29 ++++
client/tests/libvirt/tests/virt_edit.py | 218
+++++++++++++++++++++++++++++++
client/virt/libvirt_xml.py | 42 ++++++
client/virt/subtests.cfg.sample | 82 ++++++++++++
4 files changed, 371 insertions(+), 0 deletions(-)
create mode 100644 client/tests/libvirt/tests/virt_edit.py
create mode 100644 client/virt/libvirt_xml.py


Thanks Yu, I'll start going over the changes. BTW, it's much easier
for us if work is based or rebased off of the "next" branch. I know it
changes frequently, which can be frustrating. However, don't worry too
much about being up-to-the minute with next, within a day or two is fine.

It's not a big problem, especially here where I can just
s/XMLBase/XMLTreeFile/g :)

Thanks, tell me if you need any help^_^.


Actually, thanks for reminding me. I've been busy with the virsh_*() move, and probably could use some help. Would you mind rebasing it against next and re-submitting?

No need for topic-issue/tracking issue since this was already in the queue. Thanks.

--
Chris Evich, RHCA, RHCE, RHCDS, RHCSS
Quality Assurance Engineer
e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214

_______________________________________________
Autotest-kernel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/autotest-kernel

Reply via email to