On 08/29/2012 10:42 PM, Yu Mingfei wrote:
Signed-off-by: Yu Mingfei<[email protected]>
---
  client/virt/subtests.cfg.sample |   34 ++++++++++++++++++++++++++++++++++
  1 files changed, 34 insertions(+), 0 deletions(-)

diff --git a/client/virt/subtests.cfg.sample
b/client/virt/subtests.cfg.sample
index ce6918e..2606d9b 100644
--- a/client/virt/subtests.cfg.sample
+++ b/client/virt/subtests.cfg.sample
@@ -432,6 +432,40 @@ variants:
                          addition_status_error = "yes"
                          libvirtd = "off"

+    - virsh_net_create:
+        type = virsh_net_create
+        variants:
+            - with_valid_options:
+                status_error = "no"
+                options_ref = "exist_file"
+                source_file = "/etc/libvirt/qemu/networks/default.xml"
+                variants:
+                    - default_nat_config:
+                        net_name = "default"
+                        net_uuid = ""
+                    #TODO:different network config--Route,Isolate...
+            - with_invalid_options:
+                status_error = "yes"
+                variants:
+                    - none:
+                        options_ref = ""
+                    - no_exist_option:
+                        options_ref = "xyz"
+                    - additional_file:
+                        options_ref = "exist_file"
+                        extra = "xyz"
+                    - additional_option:
+                        options_ref = "exist_file"
+                        extra = "--xyz"

I missed these before (shame on me). Remember we like to have easy to identify property names because in test results, all keys just show up in one big list :( I know it's a problem in some tests I already accepted. Can we use for example virsh_net_extra, virsh_net_options_ref, virsh_net_source_file? It also helps when looking at big list of parameters to find the relevant values.

+        variants:
+            - with_libvirtd_on:
+                addition_status_error = "no"
+                libvirtd = "on"
+            - with_libvirtd_off:
+                only with_valid_options
+                addition_status_error = "yes"
+                libvirtd = "off"
+
      - module_probe:
          type = module_probe
          # You can specify your own module list, though it is not
needed usually.
-- 1.7.1

--
Best Regards
Yu Mingfei



--
Chris Evich, RHCA, RHCE, RHCDS, RHCSS
Quality Assurance Engineer
e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214

_______________________________________________
Autotest-kernel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/autotest-kernel

Reply via email to