On 09/19/2012 03:00 PM, Lucas Meneghel Rodrigues wrote:
On Wed, Sep 19, 2012 at 11:49 AM, Chris Evich <[email protected]> wrote:
Would someone mind checking this fix out real quick? I think I've got it
correct but want to make sure it works beyond my test machine. Thanks.
Yep, your patch did need some fix:
[lmr@freedom virt]$ git diff
diff --git a/client/tests/virt/virttest/virt_vm.py
b/client/tests/virt/virttest/virt_vm.py
index f87c766..94a0521 100644
--- a/client/tests/virt/virttest/virt_vm.py
+++ b/client/tests/virt/virttest/virt_vm.py
@@ -447,12 +447,12 @@ class BaseVM(object):
# Command-line encoded state doesn't include all params
# TODO: Check more than just networking
other_virtnet = utils_misc.VirtNet(params, name, self.instance)
- if self.virtnet != other_virtnet
+ if self.virtnet != other_virtnet:
logging.debug("VM params in env match, but network differs, "
"restarting")
logging.debug("\t" + str(self.virtnet))
logging.debug("\t!=")
- logging.debug("\t" + str(other_virtnet)
+ logging.debug("\t" + str(other_virtnet))
return True
else:
logging.debug("VM params in env do match requested,
continuing.")
Ok, I've just noticed that you did forget to remove the previously
implemented needs_restart method. I've just removed it:
diff --git a/client/tests/virt/virttest/virt_vm.py
b/client/tests/virt/virttest/virt_vm.py
index 94a0521..79dd08b 100644
--- a/client/tests/virt/virttest/virt_vm.py
+++ b/client/tests/virt/virttest/virt_vm.py
@@ -1084,13 +1084,6 @@ class BaseVM(object):
"""
raise NotImplementedError
- def needs_restart(self, name, params, basedir):
- """
- Based on virt preprocessing information, decide whether the VM
needs
- a restart.
- """
- raise NotImplementedError
-
def pause(self):
"""
And force pushed to next.
_______________________________________________
Autotest-kernel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/autotest-kernel
