* On 2012-09-21 11:51:34 -0300, Lucas Meneghel Rodrigues ([email protected])
wrote:
> On Fri, Sep 21, 2012 at 7:27 AM, Shuping Cui <[email protected]> wrote:
> > Signed-off-by: Shuping Cui <[email protected]>
> > ---
> > client/tests/virt/virttest/kvm_monitor.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/client/tests/virt/virttest/kvm_monitor.py
> > b/client/tests/virt/virttest/kvm_monitor.py
> > index a93d14a..a455911 100644
> > --- a/client/tests/virt/virttest/kvm_monitor.py
> > +++ b/client/tests/virt/virttest/kvm_monitor.py
> > @@ -1077,7 +1077,7 @@ class QMPMonitor(Monitor):
> > cmd_output = []
> > for cmdline in cmdlines.split(";"):
> > command = cmdline.split()[0]
> > - if self._has_command(command):
> > + if not self._has_command(command):
>
> How is this a valid change? If there's no command available, why would
> we try to execute it in the monitor?
Oh, Lucas,
This 'if' branch is used for making cmd run in HumanMonitor, when there is
no cmd in QMPMonitor,
This is a mistake made by me...
The original line here was 'if not balabala', when I update it with
'_has_command' func, I forgot the 'not' keyword..
Sorry for the inconvenience.
>
> > if "=" in cmdline:
> > command = cmdline.split()[0]
> > cmdargs = " ".join(cmdline.split()[1:]).split(",")
> > --
> > 1.7.11.4
> >
> > _______________________________________________
> > Autotest-kernel mailing list
> > [email protected]
> > https://www.redhat.com/mailman/listinfo/autotest-kernel
>
>
>
> --
> Lucas
>
> _______________________________________________
> Autotest-kernel mailing list
> [email protected]
> https://www.redhat.com/mailman/listinfo/autotest-kernel
_______________________________________________
Autotest-kernel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/autotest-kernel
