LGTM too, applied to next, thanks! On Thu, Nov 1, 2012 at 6:47 AM, Amos Kong <[email protected]> wrote: > On 11/01/2012 03:58 PM, Mike Qiu wrote: >> >> Currently, When run the test and do some clenup steps it always fail >> with lvremove command, because the lv is in used. >> Actually, the tests do fuser -k to kill users. but the it is a link >> not a file as it check if it is a file. >> >> So change the os.path.isfile to os.path.islink. >> >> Signed-off-by: Mike Qiu <[email protected]> >> --- >> kvm/tests/enospc.py | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/kvm/tests/enospc.py b/kvm/tests/enospc.py >> index 618c247..7868a3e 100644 >> --- a/kvm/tests/enospc.py >> +++ b/kvm/tests/enospc.py >> @@ -68,7 +68,7 @@ class EnospcConfig(object): >> @error.context_aware >> def cleanup(self): >> error.context("performing enospc cleanup") >> - if os.path.isfile(self.lvtest_device): >> + if os.path.islink(self.lvtest_device): > > > ACK > > Amos > > >> utils.run("fuser -k %s" % self.lvtest_device) >> time.sleep(2) >> l_result = utils.run("lvdisplay") > > > _______________________________________________ > Autotest-kernel mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/autotest-kernel
-- Lucas _______________________________________________ Autotest-kernel mailing list [email protected] https://www.redhat.com/mailman/listinfo/autotest-kernel
