On Tue, Jan 8, 2013 at 5:04 PM, Lucas Meneghel Rodrigues <[email protected]> wrote: > On Tue, Jan 8, 2013 at 1:17 PM, Vadim Bendebury <[email protected]> wrote: >> The patch just moves adding the invariant list into the return statement: >> >> + return opts + ['--reports=no', '--include-ids=y', '--rcfile=/dev/null'] >> >> is this not acceptable? > > What Amos meant, the idea looks good, but the patch is messed up, that > is, it doesn't apply. Your mailer must have messed up things pretty > badly. The correct patch is: > > diff --git a/utils/run_pylint.py b/utils/run_pylint.py > index 9d5ae84..bec6e7a 100755 > --- a/utils/run_pylint.py > +++ b/utils/run_pylint.py > @@ -83,8 +83,7 @@ def get_pylint_opts(): > else: > opts = disable_old > > - opts += ['--reports=no', '--include-ids=y'] > - return opts > + return opts + ['--reports=no', '--include-ids=y', '--rcfile=/dev/null'] > > > def check_file(file_path): > > Could you recreate the patch and resend it? Make sure you do it using > git send-email. > > Thanks! > > -- > Lucas
Ah, you are right, I did do it manually and dropped the last line of the patch (which was not changed). Did it right (hopefully!) this time :) cheers, /vb _______________________________________________ Autotest-kernel mailing list [email protected] https://www.redhat.com/mailman/listinfo/autotest-kernel
