This is the actual solution for issue #296.

The unittest with a fake server (that in fact is not
really fake, it's the barrier listen server) was
creating a rogue, paused process at the end of this
unittest run. As it uses base barrier server, it
will cause the barrier unittest to fail the next
time you run the unittests, since this process is
there holding up the barrier ports.

CC: Vinson Lee <[email protected]>
CC: Jiri Zupka <[email protected]>
Signed-off-by: Lucas Meneghel Rodrigues <[email protected]>
---
 client/shared/base_syncdata_unittest.py | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/client/shared/base_syncdata_unittest.py 
b/client/shared/base_syncdata_unittest.py
index 27a0e61..e48857a 100755
--- a/client/shared/base_syncdata_unittest.py
+++ b/client/shared/base_syncdata_unittest.py
@@ -131,11 +131,6 @@ class SyncDataTest(unittest.TestCase):
         l = lambda: sync.sync("test1", 2)
         self.assertRaises(error.DataSyncError, l)
 
-    class MockListenServer(syncdata.SyncListenServer):
-        def _server(self, address, port):
-            self.listen_server = barrier.listen_server()
-            self.exit_event.wait()
-
     def test_SyncData_with_listenServer_client_wait_timeout(self):
         sync = syncdata.SyncData("127.0.0.1", "127.0.0.1",
                                  ["127.0.0.1", "192.168.0.1"],
@@ -144,14 +139,6 @@ class SyncDataTest(unittest.TestCase):
         l = lambda: sync.single_sync("test1", 2)
         self.assertRaises(error.DataSyncError, l)
 
-    def test_SyncData_with_listenServer_fake_server(self):
-        sync = syncdata.SyncData("127.0.0.1", "127.0.0.1",
-                                 ["127.0.0.1", "192.168.0.1"],
-                                 "127.0.0.1#1", self.MockListenServer())
-
-        l = lambda: sync.single_sync("test1", 10)
-        self.assertRaises(error.DataSyncError, l)
-
     def test_SyncData_multiple_session(self):
         data_check = {}
         threads = []
-- 
1.8.1.2

_______________________________________________
Autotest-kernel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/autotest-kernel

Reply via email to