On Thu, Mar 7, 2013 at 1:53 PM, Nishanth Aravamudan
<[email protected]> wrote:
> On 27.02.2013 [22:52:19 -0300], Lucas Meneghel Rodrigues wrote:
>> On 02/27/2013 05:54 PM, Lucas Meneghel Rodrigues wrote:
>> >Great, looks good.
>>
>> Looks good, but the unittests will have to be adapted:
>
> This at least makes things pass, but I think I need to still add some
> tests that actual test that the username being passed in works. I would
> appreciate any help with that.
I'll take care of that on a followup patch. Now, I've found another problem:
> + self.parser.add_option('-N', '--username',
> + help='Specify the username to'
> + 'login with',
> + action='store', type='string',
> + dest='username', default=None)
^ Here the shorthand -N is used for other action, so there is a
conflict when running the unittests again. I've chosen another
shorthand that doesn't conflict with others (-Q) and fixed the commit
message.
So, 2 things here:
1) Remember to run the entire unittest suite to make sure there are no
side effects to your patches:
utils/unittest_suite.py --full
2) In commit messages, excerpts of an email thread are generally not
OK. Here's the commit message I've edited:
commit f791ae0a9bece928d18788ac413d35cc9470a255
Author: Nishanth Aravamudan <[email protected]>
Date: Thu Mar 7 21:53:59 2013 +0000
cli: allow username to be passed in
This is necessary for authentication schemes on the backend (LDAP, etc.).
Changes from v1:
* Fixed unittests
Signed-off-by: Nishanth Aravamudan <[email protected]>
Just point out a v2 in the subject somewhere, and explain the changes.
Cheers,
Lucas
_______________________________________________
Autotest-kernel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/autotest-kernel
