We are defaulting various lists of parameters to tuples, but they are
actually arrays. This can lead to issues when callers (the UI) aren't
passing in those members.
Reported-by: Julius Gawlas <[email protected]>
Signed-off-by: Nishanth Aravamudan <[email protected]>
---
Just throwing this on the list before I leave for the weekend. I don't
immediately see any issues, but I expect this to break the unit tests
that assume we'll get an empty tuple back or whatever. I will post a v2
with an update probably on Monday, unless someone beats me to it.
diff --git a/frontend/afe/rpc_interface.py b/frontend/afe/rpc_interface.py
index 8308e1e..66044f3 100644
--- a/frontend/afe/rpc_interface.py
+++ b/frontend/afe/rpc_interface.py
@@ -492,8 +492,8 @@ def create_parameterized_job(name, priority, test,
parameters, kernel=None,
label=None, profiles=(), profilers=(),
profiler_parameters=None,
use_container=False, profile_only=None,
- upload_kernel_config=False, hosts=(),
- meta_hosts=(), meta_host_profiles=(),
one_time_hosts=(),
+ upload_kernel_config=False, hosts=[],
+ meta_hosts=[], meta_host_profiles=[],
one_time_hosts=[],
atomic_group_name=None, synch_count=None,
is_template=False, timeout=None,
max_runtime_hrs=None, run_verify=True,
@@ -576,8 +576,8 @@ def create_parameterized_job(name, priority, test,
parameters, kernel=None,
def create_job(name, priority, control_file, control_type,
- hosts=(), profiles=(), meta_hosts=(), meta_host_profiles=(),
- one_time_hosts=(), atomic_group_name=None, synch_count=None,
+ hosts=[], profiles=[], meta_hosts=[], meta_host_profiles=[],
+ one_time_hosts=[], atomic_group_name=None, synch_count=None,
is_template=False, timeout=None, max_runtime_hrs=None,
run_verify=True, email_list='', dependencies=(),
reboot_before=None,
reboot_after=None, parse_failed_repair=None, hostless=False,
diff --git a/frontend/afe/rpc_utils.py b/frontend/afe/rpc_utils.py
index 730156e..188b1ec 100644
--- a/frontend/afe/rpc_utils.py
+++ b/frontend/afe/rpc_utils.py
@@ -640,8 +640,8 @@ def get_create_job_common_args(local_args):
def create_job_common(name, priority, control_type, control_file=None,
- hosts=(), profiles=(), meta_hosts=(),
meta_host_profiles=(),
- one_time_hosts=(), atomic_group_name=None,
synch_count=None,
+ hosts=[], profiles=[], meta_hosts=[],
meta_host_profiles=[],
+ one_time_hosts=[], atomic_group_name=None,
synch_count=None,
is_template=False, timeout=None, max_runtime_hrs=None,
run_verify=True, email_list='', dependencies=(),
reboot_before=None, reboot_after=None,
_______________________________________________
Autotest-kernel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/autotest-kernel
