On 03/12/2014 12:08 PM, Plamen Dimitrov wrote:
In some situations there is no gdm installed, old versions of qemu-kvm generate too many segmentation fault core dumps, filling up the space for results (in cases where many tests are run), etc. Therefore, making the usage of the crash handler configurable allows the final user to manually disable it.
Ah, cool, I like this. I've been meaning to write a patch to do this but always forget. Thanks a bunch, looks good.
Signed-off-by: Plamen Dimitrov <[email protected]> --- client/test.py | 3 +++ global_config.ini | 3 +++ 2 files changed, 6 insertions(+) diff --git a/client/test.py b/client/test.py index 5183e14..1f945a0 100644 --- a/client/test.py +++ b/client/test.py @@ -25,6 +25,7 @@ import resource import glob from autotest.client.shared import utils +from autotest.client.shared import settings from autotest.client.shared import test as common_test from autotest.client import os_dep @@ -63,6 +64,8 @@ class test(common_test.base_test): if (major, minor) < (2, 4): logging.warning('System python is too old, crash handling disabled') return + if not settings.settings.get_value('COMMON', 'crash_handling_enabled', type=bool): + return self.pattern_file = '/proc/sys/kernel/core_pattern' try: diff --git a/global_config.ini b/global_config.ini index 13b1264..8b645cc 100644 --- a/global_config.ini +++ b/global_config.ini @@ -73,6 +73,9 @@ test_dir: # The path for tests output directory test_output_dir: +# Crash handling for the tests +crash_handling_enabled: True + [AUTOSERV] # Autotest potential install paths _______________________________________________ Autotest-kernel mailing list [email protected] https://www.redhat.com/mailman/listinfo/autotest-kernel
_______________________________________________ Autotest-kernel mailing list [email protected] https://www.redhat.com/mailman/listinfo/autotest-kernel
