Hi Jiri, thank you very much for your work! I have comments to make
regarding to coding style as a first pass review. While reading them,
please keep in mind autotest's coding standards:

http://autotest.kernel.org/browser/trunk/CODING_STYLE

Also, I have noticed lots of trailing spaces on lines. I recommend that
every time you are done working with the code, you use the very useful
script utils/reindent.py (see top level autotest directory) that will
remove all trailing spaces on your code. While I wrote this first pass
review, I have applied it on the resultant files.


http://codereview.appspot.com/183068
_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest

Reply via email to