2010/1/4 Martin Bligh <[email protected]> > 2010/1/4 Darin Petkov <[email protected]>: > > > > > > On Mon, Jan 4, 2010 at 11:10 AM, Martin Bligh <[email protected]> wrote: > >> > >> > That's probably a better place to do it. Or you can just do it > directly > >> > in > >> > abstract_ssh.py at the top level, although code which gets executed > when > >> > the > >> > module is imported is a little messy, even if it has the advantage of > >> > just > >> > happening once, when things are loaded. > >> > Still, I'm of two minds about the automatic detection idea in general. > >> > There's no way to differentiate between rsync not being available when > >> > it > >> > shouldn't be, and it not being available when it should be; so you're > >> > stuck > >> > with either being very noisy when it isn't available which is a > problem > >> > for > >> > setups where it's not supposed to be there, or you have to be quiet > >> > about it > >> > being missing which makes it easy to overlook errors when it should be > >> > there. > >> > At least an explicit configuration option has the advantage of stating > >> > the > >> > way things should be, so that the logging can be appropriately loud or > >> > quiet. > > > > We could do a WARN (or even INFO) level message if rsync is not > executable > > on the client (and, therefore, disabled for future transfers). > > Installed, but not executable? Sure. > > In general, rsync not being installed on a client is a perfectly valid > configuration though, so this seems like a very low level priority message. >
I meant that the one-time check in AbstractSSHHost._initialize could issue a more visible INFO message (as opposed to DEBUG) if rsync is not executable on the client and, therefore, disabled for future transfers. > Moreover, what you're fixing is to log that fact once, not every time we > try > to do a transfer ;-) > You're also fixing the performance impact with trying, unsuccessfully, rsync for every file transfer. Darin
_______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
