You should use the docstring format in CODING_STYLE. Also, I do like this better as a host method, not a general function. I suggest server/hosts/remote.py, there's no reason to tie it to the ssh classes specifically. Then you can even drop both of the arguments to the function, since they're implied by self.hostname and self.job.resultdir.
-- John On Fri, Feb 12, 2010 at 1:05 PM, K.D. Lucas <[email protected]> wrote: > I wanted some jobs to select the server side component based on a platform > label, so this patch will add a function that returns the platform_label of > the specified hostname. > > Long term, I think it would be best to expose this as an attribute of the > AbstractSSHHost class, since it would then be very easy to access these > details and we wouldn't need to run any methods to grab them. I'm not > familiar enough yet with the code to understand how to best implement this, > so my work around is the attached patch. > > Kelly > > -- > K.D. Lucas > [email protected] > > _______________________________________________ > Autotest mailing list > [email protected] > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest > >
_______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
