On Wed, Jan 27, 2010 at 06:29:16AM -0500, Michael Goldish wrote:
> 
> ----- "Amos Kong" <[email protected]> wrote:
> 
> > On Mon, Jan 25, 2010 at 05:03:29AM -0500, Michael Goldish wrote:
> > > 
> > > ----- "Amos Kong" <[email protected]> wrote:
> > > 
> > > > In kvm_vm.py:
> > > > def get_image_filename(params, root_dir):
> > > >     ...
> > > >     ...
> > > >     image_name = params.get("image_name", "image")
> > > >     image_format = params.get("image_format", "qcow2")
> > > >     image_filename = "%s.%s" % (image_name, image_format)
> > > >     image_filename = kvm_utils.get_path(root_dir, image_filename)

...
> > Hello Michael,
> > 
> > Your suggestion is good, this problem should be fixed through
> > configure file.
> > Our default iso files is on '$root_dir/isos/', and I assign this
> > special 'cdrom'
> > variable below "image_name.* ?<= images/".
> > 
> > --------
> >  image_name.* ?<= images/
> >  cdrom.* ?<= isos/
> >  steps ?<= steps/
> > 
> > +cdrom:
> > +    cdrom = /tmp/orig.iso
> > +
> > --------
> 
> The 'cdrom:' statement is probably not what you want, because you're supposed
> to put a regex that matches test names before the ':' (e.g. 'install:' or
> 'Fedora.11:'), not parameter names.  What you did makes sense only if you
> have tests that contain the string 'cdrom' in their names.  The effect of the
> config lines you provided is that all tests will expect their ISOs under isos/
> except the tests named 'cdrom', which will expect their ISO at /tmp/orig.iso.

Yes, my test name is 'cdrom'. I just want to adjust the value of 'cdrom' in 
this test.

Amos

-- 
Amos Kong
_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest

Reply via email to