Looks good. On Wed, Feb 24, 2010 at 4:05 PM, Darin Petkov <[email protected]> wrote:
> > > On Wed, Feb 24, 2010 at 3:44 PM, John Admanski <[email protected]>wrote: > >> logging.error("%s: %s" % (test_name, e)) >> >> >> should be: >> >> logging.error("%s: %s", test_name, e) >> >> With the logging you don't do the % interpolation yourself, the logging >> framework does it. >> >> > Sure. Fixed. > >> >> Also, don't use the form "string.find(x) >= 0" when trying to see if a >> string contains x, use "x in string" (or "x not in string" for the opposite >> case). >> >> > I assume this was an FYI rather than a review comment given that this > statement wasn't part of this patch. Anyway, fixed it so that it actually > works and doesn't match if a test name happens to contain the substring > "all". > > New patch attached. PTAL. > > Thanks, > > Darin > >> >> >> -- John >> >> >> On Wed, Feb 24, 2010 at 3:31 PM, Darin Petkov <[email protected]> wrote: >> >>> Fix setup_job so that it doesn't fail at load_all_client_tests if a >>> test in the tree is broken. Collect and print the broken tests (if we were >>> to actually build them). >>> >>> >>> _______________________________________________ >>> Autotest mailing list >>> [email protected] >>> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest >>> >>> >> >
_______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
