iptables: is probably worth checking iptables is running on the system (binaries there and kernel has support) before trying to configure it ... and it should probably get reset back somehow after use?
maybe also move this to an abstraction in net_utils, since two callers use it (eg disable_firewall(), then have the cleanup() test method call reenable_firewall() or something). On Fri, Feb 26, 2010 at 4:40 PM, K.D. Lucas <[email protected]> wrote: > So I've split the netpipe and netperf control files into separate control > files and a .py file for each one, so that it will be easier to add > additional tests that use the logic of the python scripts without > duplicating code. > I'm also taking advantage of the new added function to get the > platform_label, as in my testbed I have assigned a net_server platform label > for the machines I want to use as the network side of these tests. > Let me know your thoughts on this, as some of you might think the stress > version of these tests belongs in a site_tests directory. But definitely > splitting the code out with the reusable code in a separate python scripts > seems like a good idea. > Regards, > Kelly > -- > K.D. Lucas > [email protected] > > _______________________________________________ > Autotest mailing list > [email protected] > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest > > _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
