This sounds fine to me - since the test is normally being built on the machine on which it is going to be run there is no need to build a static linked binary.
I suspect that the --static in the Makefile is just a throwback to some point in time at which I was building the test on a development machine and running it on a number of test systems which were not guaranteed to have a compatible set of shared libraries on them, md On Tue, Mar 23, 2010 at 11:25 AM, Martin Bligh <[email protected]> wrote: > +cc:md (he wrote the test). > > On Tue, Mar 23, 2010 at 11:13 AM, Lucas Meneghel Rodrigues > <[email protected]> wrote: > > The Makefile for the monotonic_test C program forces static > > compilation of the object files. Since we are compiling the > > code already, not having a static binary doesn't make much > > of a difference on the systems we are running this test. > > > > As the static compilation might fail in some boxes, just remove > > this constraint from the Makefile. > > I presume this was to fix some Google interdependency. > Is it actually breaking something? If not, seems safer to leave it? > If so, we'll have to fix one end or the other ;-) > > > Signed-off-by: Lucas Meneghel Rodrigues <[email protected]> > > --- > > client/tests/monotonic_time/src/Makefile | 1 - > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > > diff --git a/client/tests/monotonic_time/src/Makefile > b/client/tests/monotonic_time/src/Makefile > > index 56aa7b6..2121ec4 100644 > > --- a/client/tests/monotonic_time/src/Makefile > > +++ b/client/tests/monotonic_time/src/Makefile > > @@ -1,7 +1,6 @@ > > CC= cc > > > > CFLAGS= -O -std=gnu99 -Wall > > -LDFLAGS=-static > > LIBS= -lpthread -lrt > > > > PROG= time_test > > -- > > 1.6.6.1 > > > > _______________________________________________ > > Autotest mailing list > > [email protected] > > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest > > >
_______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
