----- "Dor Laor" <[email protected]> wrote: > On 03/25/2010 05:35 AM, Lucas Meneghel Rodrigues wrote: > > On Wed, 2010-03-24 at 14:31 +0800, Jason Wang wrote: > >> We should also test timedrift for Linux guests especially for > guest > >> with pvclock. So this patch enable the timedrift for linux guests. > >> > >> Changes from v1: > >> - Correct the wrong name for guest load cleaning > >> - Use -no-kvm-pit-reinjection for linux guests and -rtc-td-hack > for > >> windows guests. > > > > Ok, I was wondering whether we should make the options -rtc-td-hack > and > > -no-kvm-pit-reinjection as variants in our default test set (I > guess > > testing timedrift with/without those options might be useful). > Michael, > > do you have an opinion on this regard? > > We should. The -no-kvm-pit-reinjection should apply only for Linux > guests but it does hurt non standard HAL win guests which is the > default. So to simplify things you can always enable it. > > -rtc-td-hack should also be enabled. Upstream has a new format for > it: -rtc driftfix=slew
I'm not sure I understand. Do you mean that - we should run all tests twice (with and without -rtc-td-hack)? - we should run timedrift tests twice (with and without -rtc-td-hack)? - we should run all tests with -rtc-td-hack? The same goes for -no-kvm-pit-reinjection. > > > >> > >> Signed-off-by: Jason Wang<[email protected]> > >> --- > >> client/tests/kvm/tests_base.cfg.sample | 14 ++++++++++++-- > >> 1 files changed, 12 insertions(+), 2 deletions(-) > >> > >> diff --git a/client/tests/kvm/tests_base.cfg.sample > b/client/tests/kvm/tests_base.cfg.sample > >> index 8cc83a9..29a2430 100644 > >> --- a/client/tests/kvm/tests_base.cfg.sample > >> +++ b/client/tests/kvm/tests_base.cfg.sample > >> @@ -147,7 +147,6 @@ variants: > >> type = linux_s3 > >> > >> - timedrift: install setup unattended_install > >> - extra_params += " -rtc-td-hack" > >> variants: > >> - with_load: > >> type = timedrift > >> @@ -330,7 +329,7 @@ variants: > >> variants: > >> # Linux section > >> - @Linux: > >> - no timedrift autoit > >> + no autoit > >> shutdown_command = shutdown -h now > >> reboot_command = shutdown -r now > >> status_test_command = echo $? > >> @@ -342,6 +341,16 @@ variants: > >> file_transfer_port = 22 > >> mem_chk_cmd = dmidecode -t 17 | awk -F: '/Size/ {print > $2}' > >> cpu_chk_cmd = grep -c processor /proc/cpuinfo > >> + timedrift: > >> + extra_params += " -no-kvm-pit-reinjection" > >> + time_command = date +'TIME: %a %m/%d/%Y %H:%M:%S.%N' > >> + time_filter_re = "(?:TIME: \w\w\w )(.{19})(?:\.\d\d)" > >> + time_format = "%m/%d/%Y %H:%M:%S" > >> + guest_load_command = "dd if=/dev/urandom > of=/dev/null" > >> + guest_load_instances = 2 > >> + guest_load_stop_command = "killall -9 dd" > >> + host_load_command = "bzip2 -c --best /dev/urandom> > /dev/null" > >> + host_load_instances = 8 > >> > >> variants: > >> - Fedora: > >> @@ -717,6 +726,7 @@ variants: > >> stress_boot: > >> alive_test_cmd = systeminfo > >> timedrift: > >> + extra_params += " -rtc-td-hack" > >> time_command = "echo TIME: %date% %time%" > >> time_filter_re = "(?<=TIME: \w\w\w ).{19}(?=\.\d\d)" > >> time_format = "%m/%d/%Y %H:%M:%S" > >> > >> _______________________________________________ > >> Autotest mailing list > >> [email protected] > >> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest > > > > > > _______________________________________________ > > Autotest mailing list > > [email protected] > > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest > > _______________________________________________ > Autotest mailing list > [email protected] > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
