I was looking at this a bit more, and I still see an issue; now you can't write code that uses args that just works on a straight client, you have to be launching the client via autoserv. I suppose that's not a huge problem, since autoserv is the only way that you can set args anyway, but I guess I'd just envisioned a grander patch that actually added support for command-line args to client/bin/autotest, and then just used server/autotest.py to pass through any autoserv args.
Still, I think it's not a huge deal. I'm just a little worried about the continued trend of more and more code being written that just assumes you're using all the higher layers to run your tests. These days it seems everyone just wants to write client tests that assume you're using autoserv, or even assumes you're using a full scheduler setup. -- John On Fri, Mar 26, 2010 at 3:08 PM, Darin Petkov <[email protected]> wrote: > > > On Fri, Mar 26, 2010 at 2:43 PM, John Admanski <[email protected]>wrote: > >> This should probably use %r instead of %s. In practice I think repr(args) >> and str(args) will end up being the same, but in principle repr is supposed >> to be the inverse of eval so it's the more correct choice of formatting. > > > Good point. Updated the patch. PTAL. > > >> >> >> On Fri, Mar 26, 2010 at 2:40 PM, Darin Petkov <[email protected]> wrote: >> >>> A simple patch to propagate user args (autoserv -a/--args) to the >>> client-side control file. >>> >>> >> >
_______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
