On Thu, 2010-06-10 at 06:37 +0800, Amos Kong wrote: > Autotest maybe used to test some new features/options which have been > implemented, but the help message didn't been updated. This patch just give > us a > free way to tell framework which option has been supported.
This is a legitimate bug as I see it. When there's a mismatch between supported options and the program help, it's a bug and we should fix it instead of working around it. Copying Avi and Anthony. > Signed-off-by: Amos Kong <[email protected]> > --- > 0 files changed, 0 insertions(+), 0 deletions(-) > > diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py > index f3ce4d6..70ff2bb 100755 > --- a/client/tests/kvm/kvm_vm.py > +++ b/client/tests/kvm/kvm_vm.py > @@ -280,6 +280,7 @@ class VM: > # returns or causes some other kind of trouble) > logging.debug("Getting output of 'qemu -help'") > help = commands.getoutput("%s -help" % qemu_binary) > + help += "\n%s" % params.get("extra_help_options") > > # Start constructing the qemu command > qemu_cmd = "" > diff --git a/client/tests/kvm/tests_base.cfg.sample > b/client/tests/kvm/tests_base.cfg.sample > index d55b2be..db8f516 100644 > --- a/client/tests/kvm/tests_base.cfg.sample > +++ b/client/tests/kvm/tests_base.cfg.sample > @@ -52,6 +52,8 @@ run_tcpdump = yes > # Misc > profilers = kvm_stat > > +# Assign some qemu options which have been implemented, but not updated to > help message > +#extra_help_options = netdev vhost > > # Tests > variants: > _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
