On Wed, 2010-09-29 at 13:35 -0700, James Ren wrote: > Have the HttpFetcher in the packaging system check for HTTP repository > connectivity using the full repository base URL rather than just the server > name.
LGTM :) Lucas > Signed-off-by: James Ren <[email protected]> > > --- autotest/client/common_lib/base_packages.py 2010-06-22 > 10:24:16.000000000 -0700 > +++ autotest/client/common_lib/base_packages.py 2010-09-29 > 13:24:32.000000000 -0700 > @@ -119,14 +119,13 @@ > dest_file_path = self.run_command(mktemp).stdout.strip() > > try: > - # build up a wget command using the server name > - server_name = urlparse.urlparse(self.url)[1] > - http_cmd = self.wget_cmd_pattern % (server_name, dest_file_path) > + # build up a wget command > + http_cmd = self.wget_cmd_pattern % (self.url, dest_file_path) > try: > self.run_command(http_cmd, _run_command_dargs={'timeout': > 30}) > except Exception, e: > msg = 'HTTP test failed, unable to contact %s: %s' > - raise error.PackageFetchError(msg % (server_name, e)) > + raise error.PackageFetchError(msg % (self.url, e)) > finally: > self.run_command('rm -rf %s' % dest_file_path) > _______________________________________________ > Autotest mailing list > [email protected] > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
