On Sat, 2010-08-14 at 21:05 +0800, Amos Kong wrote: > kvm_subprocess: Reset _thread_kill_requested after tail_thread quit > > From: Amos Kong <[email protected]> > > If iterations of test is larger than 1, tcpdump process would be killed at the > end of iterations.1, then global 'thread_kill_requested' becomes 'True', in > iterations.2 tcpdump process would also be immediately killed after launch. > So we need reset '_thread_kill_requested' to 'False' after tail_thread quit.
Well Amos, I've reviewed this and think this is OK. Michael had mentioned he didn't quite agree with the solution, but I have checked it and couldn't figure a better way to do it, so applied, r4848. Cheers, Lucas > Signed-off-by: Amos Kong <[email protected]> > --- > client/tests/kvm/kvm_subprocess.py | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/client/tests/kvm/kvm_subprocess.py > b/client/tests/kvm/kvm_subprocess.py > index f815069..580f71d 100755 > --- a/client/tests/kvm/kvm_subprocess.py > +++ b/client/tests/kvm/kvm_subprocess.py > @@ -706,6 +706,7 @@ class kvm_tail(kvm_spawn): > while True: > global _thread_kill_requested > if _thread_kill_requested: > + _thread_kill_requested = False > return > try: > # See if there's any data to read from the pipe _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
