On Wed, 2010-10-27 at 15:38 +0530, pradeep wrote: > On Tue, 26 Oct 2010 15:21:13 +0800 > Jason Wang <[email protected]> wrote: > > > Pradeep Kumar writes: > > > This patch is for Ping6 testing > > > > > > * ping6 with various message sizes guest to/from local/remote > > > host using link-local addresses > > > By default IPv6 seems to be disabled on virbr0. Enable it by > > > doing echo 0 > /proc/sys/net/ipv6/conf/virbr0/disable_ipv6 > > > > > > Signed-off-by: Pradeep K Surisetty <[email protected]> > > > --- > > > --- autotest/client/tests/kvm/tests/ping.py 2010-10-07 > > > 09:53:15.000000000 +0530 +++ > > > autotest_new/client/tests/kvm/tests/ping.py 2010-10-25 > > > 18:28:26.326891567 +0530 @@ -1,5 +1,6 @@ -import logging > > > +import logging, time > > > from autotest_lib.client.common_lib import error > > > +from autotest_lib.client.bin import utils > > > import kvm_test_utils > > > > > > > > > @@ -26,11 +27,19 @@ def run_ping(test, params, env): > > > flood_minutes = float(params.get("flood_minutes", 10)) > > > nics = params.get("nics").split() > > > strict_check = params.get("strict_check", "no") == "yes" > > > - > > > + address_type = params.get("address_type") > > > + #By default IPv6 seems to be disabled on virbr0. > > > + ipv6_cmd = "echo %s > > > > /proc/sys/net/ipv6/conf/virbr0/disable_ipv6" > > > > How about do this in qemu-ifup? becuase the virbr0 is hardcoded here > > Thanks for your comments. > > I feel virbr0 hard code should be fine. > if really needed, we can do this in qemu-ifup.
^ Pradeep, sorry for being late commenting on this. Jason is right on spot here. What I'd like to see here: * Have an alternate qemu-ifup script that enables ipv6 on the specified bridge, and have it defined on the appropriate variant block: nic_script = scripts/qemu-ifup-ipv6 or something like that So we don't need modification to the test code at all. Could work on that and send an updated patch? Thanks! Lucas _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
