On Thu, 2010-12-09 at 12:49 -0500, Lucas Meneghel Rodrigues wrote:
> On Fri, 2010-11-26 at 12:02 +0100, Frank Becker wrote:
> > From: Frank Becker <[email protected]>
Hi,
> Hi Frank, was reviewing your patchset, and I must say the feature is
> implemented cleanly and in a minimally intrusive way, congrats! I have
> noticed some changes I do not agree with, see below:
Thank you.
> > ---
> > client/bin/job.py | 24 +++++++++++++++---------
> > 1 files changed, 15 insertions(+), 9 deletions(-)
> >
> > diff --git a/client/bin/job.py b/client/bin/job.py
> > index 3d552ce..141feab 100644
> > --- a/client/bin/job.py
> > +++ b/client/bin/job.py
> > @@ -162,9 +162,9 @@ class base_client_job(base_job.base_job):
> > self._cleanup_results_dir()
> >
> > logging_manager.configure_logging(
> > - client_logging_config.ClientLoggingConfig(),
> > - results_dir=self.resultdir,
> > - verbose=options.verbose)
> > + client_logging_config.ClientLoggingConfig(),
> > + results_dir=self.resultdir,
> > + verbose=options.verbose)
> > logging.info('Writing results to %s', self.resultdir)
> >
> > # init_group_level needs the state
> > @@ -190,8 +190,8 @@ class base_client_job(base_job.base_job):
> > # send the entry to stdout, if it's enabled
> > logging.info(rendered_entry)
> > self._logger = base_job.status_logger(
> > - self, status_indenter(self),
> > record_hook=client_job_record_hook)
> > -
> > + self, status_indenter(self),
> > record_hook=client_job_record_hook,
> > + tap_writer=self._tap)
> >
> > def _post_record_init(self, control, options, drop_caches,
> > extra_copy_cmdline):
> > @@ -663,8 +663,7 @@ class base_client_job(base_job.base_job):
> > # check to see if any partitions have changed
> > partition_list = partition_lib.get_partition_list(self,
> >
> > exclude_swap=False)
> > - mount_info = partition_lib.get_mount_info(partition_list)
> > -
> > + mount_info = set((p.device, p.get_mountpoint()) for p in
> > partition_list)
>
> ^ What was the purpose of this change? With get_mount_info we have a
> more reliable method of identifying the devices on newer distros, and it
> has a fallback in case blkid is not available...
I am sorry. That revert of a former commit should not be in there. On git
(git://github.com/autotest/autotest.git)
it was commit
78a07d5e4ac6332f751c833e02501582e9a11f6b or
git-svn-id: svn://test.kernel.org/autotest/tr...@4876 \
592f7852-d20e-0410-864c-8624ca9c26a4
My fault.
I'll send a new patch set on Monday.
> > old_mount_info = self._state.get('client', 'mount_info')
> > if mount_info != old_mount_info:
> > new_entries = mount_info - old_mount_info
> > @@ -783,7 +782,7 @@ class base_client_job(base_job.base_job):
> > # save the partition list and mount points, as well as the cpu
> > count
> > partition_list = partition_lib.get_partition_list(self,
> >
> > exclude_swap=False)
> > - mount_info = partition_lib.get_mount_info(partition_list)
> > + mount_info = set((p.device, p.get_mountpoint()) for p in
> > partition_list)
>
> ^ Same here. Maybe you are having trouble with get_mount_info? Please
> elucidate.
Right, same here :)
Bye,
Frank
_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
