On Wed, 2011-01-05 at 21:47 +0100, Frank Becker wrote:
> From: Frank Becker <frank.bec...@amd.com>
> 
> Hi,
> 
> This is a resend of the patch to add TAP support to the Autotest client
> that was reverted by r4984 (git 69a08d5). Sorry for the delay, I was out
> of office.
> 
> The unittests of
>     client/common_lib/base_job_unittest.py
> now pass. I did not change patch0001 to patch0005. Patch0006 changes
> status_logger() and TAPReport() a bit to make the unittests pass.
> 
> The old description for reverence:
> This patch series adds some basic TAP support to the Autotest client.
> The reason behind it is to integrate Autotest into our internal testing
> system which is based on TAP (Test Anything Protocol)[0] known from
> Perl's CPAN. While doing that, my main goal was to be as less intrusive
> as possible. Also, the TAP support is completely optional.
> 
> Example of running the hackbench benchmark w/ TAP.
> 
>     client/bin/autotest --tap client/tests/hackbench/control
> 
> That will give you some additional *.tap files (status.tap, keyval.tap)
>     # find client/results -iname "*tap"
>     client/results/default/hackbench/results/keyval.tap
>     client/results/default/hackbench/status.tap
>     client/results/default/hackbench/keyval.tap
>     client/results/default/status.tap
> 
> Further, it creates a tar.gz containing all *.tap files and a meta.yml
> catalog suitable for TAP::Archive [1]

Hi Frank, looks good to me, now autotest client has TAP support :) See:

http://autotest.kernel.org/changeset/5068
http://autotest.kernel.org/changeset/5069
http://autotest.kernel.org/changeset/5070
http://autotest.kernel.org/changeset/5071
http://autotest.kernel.org/changeset/5072
http://autotest.kernel.org/changeset/5073

I only ask you to take more care writing more explanatory messages on
future patches and make sure you add a Signed-off-by: Your Name there.

Thank you very much!

Lucas

> 
> Frank Becker (6):
>   Added --tap option to client based test runs
>   add cls TAPReport() and make cls base_job() init tap reporting if
>     option is set
>   added optional TAP to write_keyvalue func
>   write TAP when cls job() exits
>   make cls test() handle TAP if --tap option is set
>   init TAPReport() without parameters to pass unittests
> 
>  client/bin/autotest             |    5 +
>  client/bin/job.py               |   18 ++--
>  client/common_lib/base_job.py   |  207 
> ++++++++++++++++++++++++++++++++++++++-
>  client/common_lib/base_utils.py |    9 ++-
>  client/common_lib/test.py       |   18 ++--
>  5 files changed, 240 insertions(+), 17 deletions(-)
> 
> [0] http://en.wikipedia.org/wiki/Test_Anything_Protocol
>     http://szabgab.com/blog/2009/04/1239191451.html
> [1] http://www.ietf.org/mail-archive/web/tap/current/msg00455.html
> 
> Thanks a lot!
> 
>     Frank
> 
> _______________________________________________
> Autotest mailing list
> Autotest@test.kernel.org
> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest


_______________________________________________
Autotest mailing list
Autotest@test.kernel.org
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest

Reply via email to