LGTM. If there is no any other objection, I gonna apply this patch within couple of hours.
Eric On Tue, Feb 1, 2011 at 1:54 PM, David Rochberg <rochb...@chromium.org>wrote: > [patch attached as well due to space/tab breakage. > resent as list member.] > > SIGTTOU was causing a hang in terminals with tostop set (which seems to be > the default for my local emacs configuration). > > Signed-off-by: David Rochberg (rochb...@chromium.org) > BUG=chromiumos:7716 > TEST=stty tostop, then run with and without this change. Without the > change, tests will hang in a SIGTTOU/syscall-restarted loop. > > Change-Id: Ib5317e238b68089d71e8e57418717e7553fd64d9 > > Review URL: http://codereview.chromium.org/6368022 > --- > server/autoserv | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/server/autoserv b/server/autoserv > index b3e900b..1cec992 100755 > --- a/server/autoserv > +++ b/server/autoserv > @@ -53,6 +53,9 @@ def run_autoserv(pid_file_manager, results, parser): > # Set signal handler > signal.signal(signal.SIGTERM, handle_sigterm) > > + # Ignore SIGTTOU's generated by output from forked children. > + signal.signal(signal.SIGTTOU, signal.SIG_IGN) > + > # Server side tests that call shell scripts often depend on $USER > being set > # but depending on how you launch your autotest scheduler it may not > be set. > os.environ['USER'] = getpass.getuser() > -- > 1.7.3.1 > > > _______________________________________________ > Autotest mailing list > Autotest@test.kernel.org > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest > > -- Eric Li 李咏竹 Google Kirkland
_______________________________________________ Autotest mailing list Autotest@test.kernel.org http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
