On 02/10/2011 01:03 PM, Avi Kivity wrote: > On 02/10/2011 12:57 PM, Michael Goldish wrote: >> > >> > I can't easily think of a case where this might cause confusion. The >> > purpose of this is to allow people to write: >> > >> > only qcow2..raw..rtl8139 >> > >> > without having to remember the order in which those were defined in >> > tests_base.cfg. >> >> Sorry, I meant something like >> >> only qcow2..hugepages..rtl8139 >> >> Obviously qcow2 and raw can't coexist. > > The config files describe a cartesian product, in which order matters. > > [A B C] x [1 2] generates [A1 A2 B1 B2 C1 C2]; no confusion here if you > specify A..1 > > however > > [A B C] x [A B] generates [AA AB BA BB CA CB]; A..B is ambiguous
This is a bad idea anyway: [A B C] x [A B] x [install boot migrate] 'only A..install' is ambiguous regardless of whether we match in-order or not. > we might require that keywords be unique. Ambiguity can be resolved by prefixing a name with its immediate parent. If we have Fedora.9.32 and Fedora.9.64, and some test 'foo' has both a 32 bit and a 64 bit version, then the following isn't ambiguous: only Fedora.9.32..foo.32 If we require that keywords be unique, such combinations will not be possible. The same applies to RHEL.3..sometest.3. _______________________________________________ Autotest mailing list Autotest@test.kernel.org http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
