LGTM On Mon, Feb 28, 2011 at 5:14 PM, Dale Curtis <dalecur...@google.com> wrote:
> In order to facilitate site extensibility of HostScheduler we need to > factor out the dependence on global variables in monitor_db. I modeled this > refactoring off of monitor_db_cleanup. > > The main changes I've made are as follows: > 1. Move BaseHostScheduler, site import, and SchedulerError out of > monitor_db. SchedulerError must be moved to prevent a cyclical dependency. > 2. Convert staticmethod/classmethods in BaseHostScheduler to normal > methods. > 3. Fix unit tests and monitor_db to import SchedulerError from > host_scheduler. > > Reviewable at: http://codereview.chromium.org/6597047/ > > Signed-off-by: Dale Curtis <dalecur...@google.com> > --- > scheduler/host_scheduler.py | 424 +++++++++++++++++++++++++++++++++++++++ > scheduler/monitor_db.py | 457 > ++----------------------------------------- > 2 files changed, 444 insertions(+), 437 deletions(-) > create mode 100644 scheduler/host_scheduler.py > > > _______________________________________________ > Autotest mailing list > Autotest@test.kernel.org > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest > >
_______________________________________________ Autotest mailing list Autotest@test.kernel.org http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
