于 2011年11月18日 22:10, Lucas Meneghel Rodrigues 写道: > On 11/18/2011 11:51 AM, Xu He Jie wrote: >> 于 2011年11月18日 21:34, Lucas Meneghel Rodrigues 写道: >>> On 11/18/2011 05:04 AM, Xu He Jie wrote: >>>> the different with last version: >>>> * Move url argument to last position for virsh_*. >>>> * Add driver_type 'default', and 'default' as default value for >>>> driver_type. >>>> * When VM.remove() failed, it will raise an exception. And add new >>>> exception 'VMRemoveError'. >>>> * Other small fix. >>>> >>>> When I run libvirt test, the driver of libvirt will decide >>>> by virsh. >>>> >>>> So I add option of 'driver_type' that can specify which driver >>>> libvirt will connect to. >>>> >>>> but now just can specify two type of driver 'qemu and xen', >>>> if specify other driver will use default driver that >>>> detected by virsh. >>> >>> Looks good, you may prepare v3 >> >> Thanks for your review! >> >> But I found VM.create() will use virt-install to create VM, so I guess >> we need pass url to virt-install too. >> >> And there is an option 'use_connect_uri = yes' in tests_base.cfg.sample, >> but I didn't find somewhere using that. > > You might try make virt-install to use that option, perhaps?
If 'use_connect_uri' means using a url to connect to libvirt, I suggest remove 'use_connect_uri' from tests_base.cfg. 'driver_type = default' means 'use_connect_uri = no', and other value for driver_type means 'use_connect_uri = yes' > >> So I just pass uri to virt-install will be OK? > > If it works, I see no problem :) > _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
