On 12/01/2011 02:37 PM, Frank Becker wrote: > On 29.11.11 03:16, Lucas Meneghel Rodrigues wrote: >> On 11/19/2011 03:15 PM, Frank Becker wrote: >>> On 31.08.10 07:56, divya wrote: > > Hi, > >> I've looked at the issue. What divya was trying to do was to import the >> GitRepo class straight from server/git.py in order to work on the LTP >> client test (if I am guessing correctly, the idea is to fetch/clone LTP >> from a git repo). >> >> Turns out this module can't be imported from server, as the client does >> not see anything on the server API realm. The >> client.common_lib.version_control lib does contain the GitRepo >> implementation he could have used. >> >> However, I believe that API is not as convenient as the one we have been >> using on the virt tests, hence, we've put together pull request #95, as >> well as send the patches to the mailing list. >> >> https://github.com/autotest/autotest/pull/95 >> >> I believe it's a better solution (needs a bit more work), so once this >> is upstream divya can resume with checking out git code on tests. >> >> I'd love to hear some feedback on this approach, > No question, it's valuable to have git available on the client side. > > Unfortunately, the now pulled request breaks the old > GitKernel(git.InstallableGitRepo) quite heavily. > > On the old GitKernel I was using e. g. the following methods that are > not implemented anymore: > .get() > .get_local_head() > .gitcmd() > .get_branch() > > There are more. > > I guess it's time to rewrite all those control files :-/ Further, I'd > like to have at least .gitcmd() back. > > So, bottom line: The new implementation should implement the > functionality of the old one. I don't mind if .get() now is called > .fetch(). I do mind that it only provides a sub set of the > implementation prior d512f2644c5bbaa0c438b69374b9c3423df97c1f.
Ok, will work on that, sorry about that. > Bye, > > Frank > _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
