On 12/04/2011 11:49 PM, Qingtang Zhou wrote: > * On 2011-12-02 14:10:14 -0500, Chris Evich ([email protected]) wrote: >> Signed-off-by: Chris Evich<[email protected]> >> --- >> client/tests/libvirt/tests/boot_savevm.py | 37 >> +++++++++++++++-------------- >> 1 files changed, 19 insertions(+), 18 deletions(-) > Hi Chris, > Glad to see more and more libvirt tests in autotest, but is it a good > idea to copy every case to libvirt tests directory? It may make many > duplicated code and hard to maintain these tests. > > For this test, We can put it in virt/tests directory, and add the > missing method (savevm/loadvm pause/resume) in both kvm_vm/libvirt_vm. > What's your idea, Chris. > If you agree, I'd like to add the missing interfaces in kvm part.
Hi, In general I agree, the test shouldn't be tied to a specific hypervisor monitor class. The challenge here is that the libvirt monitor class isn't complete or being used. Those are the two roadblocks to having tests like this shared more between engine types. Thanks for offering to help implement the missing functions. I had actually already done this, but forgot to send up that patch. Working on tracking it down now... -- Chris Evich, RHCA, RHCE, RHCDS, RHCSS Quality Assurance Engineer e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214 _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
