Hi~ Sure, I prefer prefix the names with "virsh_migrate_". I will resent these patches later. Thanks for the comments:)
By the way, my colleagues and I are testing libvirt now. And we have a lot of cases for libvirt commands. I'm thinking that maybe I can add some of them to Autotest, put them into client/tests/libvirt/tests/ directory. What do you think about that? On 01/17/2012 10:11 PM, Chris Evich wrote: > On 01/16/2012 10:21 PM, tangchen wrote: >> Hi~ >> >> 1. There is no muigrate() function in class VM in libvirt_vm.py. >> 2. There is no tests for libvirt in client/tests/libvirt. >> >> So, I would like to add some tests for libvirt. >> >> Here are three patches, >> >> 1. Add a migrate() function for class VM in libvirt_vm.py, which >> encapsulates "virsh migrate" command. >> 2. Add a "tests" directory in client/tests/libvirt/, and a test >> for "virsh migrate" command. >> 3. Add configuration for this test. >> > > Hi, > > Thanks for adding this, it's something that was sorely needed for the libvirt > tests! I looked over all the patches and test code, they seem reasonable to > me. There was only one little thing I wanted to mention, (and perhaps others > will disagree it's a problem at all): > > The param dict key names are very generic sounding, which may impact test > debugging and general readability. What do you think about prefixing the > names with 'virsh_', 'libvirt_migrate_', or 'virsh_migrate_' (or anything > like that)? > > Bug thanks again for adding this, I'm excited to put it to use! > -- Best Regards, Tang chen _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
