On 03/07/2012 10:53 PM, guyanhua wrote: > > This adds configuration for "virsh capabilities" test. > > Signed-off-by: Gu Yanhua<[email protected]> > --- > client/virt/subtests.cfg.sample | 17 +++++++++++++++++ > 1 files changed, 17 insertions(+), 0 deletions(-) > > diff --git a/client/virt/subtests.cfg.sample b/client/virt/subtests.cfg.sample > index 90170c8..905fbe0 100644 > --- a/client/virt/subtests.cfg.sample > +++ b/client/virt/subtests.cfg.sample > @@ -218,6 +218,23 @@ variants: > status_error = "yes" > libvirtd = "off" > > + - virsh_capabilities: > + type = virsh_capabilities > + vms = '' > + variants: > + - no_option: > + options = "" > + status_error = "no" > + libvirtd = "on" > + - unexpect_option: > + options = "xyz" > + status_error = "yes" > + libvirtd = "on" > + - with_libvirtd_stop: > + options = "" > + status_error = "yes" > + libvirtd = "off" > + > > - module_probe: > type = module_probe > -- > 1.7.1 > > _______________________________________________ > Autotest mailing list > [email protected] > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
I'd much prefer to see more qualified parameter key names, if only because it makes debugging things easier. After tests run, the results just store one big list of key=value, so with generic sounding keys like 'options' and 'libvirtd' mixed it, it can be misleading. How about prefixing them with 'virsh_cap_' or something like that? I really like the tests overall, and I think checking for the 'bad option' case is really smart. Thanks for the contributions! -- Chris Evich, RHCA, RHCE, RHCDS, RHCSS Quality Assurance Engineer e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214 _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
