On Mon, Mar 19, 2012 at 10:16 AM, Yogesh Kulkarni <gnun...@gmail.com> wrote:
> Hi,
>
> While adding tests on the server side, we use 'utils/test_importer.py' with
> -t "path to the test directory" and while specifying tests for particular
> job we use
> "./cli/atest job create .... -t <added tests> ...."
>
> But with some tests e.g. "cyclictest, signaltest", after executing
>
> utils/test_importer.py -t client/tests/cyclictest, the test is listed as
> cyclic_test. While specifying cyclictest in the job we need to specify it as
> cyclic_test.
> This requires unnecessary change in the automation scripts that adds test to
> the server and specifies some of the added tests for the job.
> Also the listing of tests is not uniform like
>
> client/tests/cyclictest listed as cyclic_test
>
> client/tests/signaltest  listed as Signal Test
>
> Any clarification on this issue will be of great help.

The test_importer script helps to show information about the test in
the web interface. The test listing you are referring to is what is
set on the NAME variable of the sample control file. Example:

AUTHOR = 'Martin Bligh <mbl...@google.com>'
DOC = '''
description rt test utils
URL http://www.kernel.org/pub/scm/linux/kernel/git/tglx/rt-tests.git
'''
NAME = 'cyclic_test'
TIME = 'MEDIUM' ## ?
EXPERIMENTAL = 'True'
TEST_CLASS = 'kernel'
TEST_CATEGORY = 'Functional'
TEST_TYPE = 'client'

job.run_test('cyclictest')


NAME='Signal Test'
AUTHOR='Michal Piotrowski <michal.k.k.piotrow...@gmail.com>'
TIME='SHORT'
TEST_TYPE='client'
TEST_CLASS='Kernel'
TEST_CATEGORY='Functional'
DOC='''\
Test signal passing to processes
'''
job.run_test('signaltest')


I agree that we can standardize the naming, however this NAME is not
used on the cli -t value. The actual value is used from the name of
the directory under client/tests.

So bottom line, focus on the directory names, rather than the NAME
variable. This variable is more a human readable name to help people
browsing through the web interface.

That said, we are happily accepting patches that make all NAME
variables on all control files uniform.

Cheers,

-- 
Lucas
_______________________________________________
Autotest mailing list
Autotest@test.kernel.org
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest

Reply via email to