On Tue, May 22, 2012 at 4:24 PM, DeFolo, Daniel <daniel.def...@hp.com> wrote:
>
>
>> -----Original Message-----
>> From: autotest-boun...@test.kernel.org [mailto:autotest-
>> boun...@test.kernel.org] On Behalf Of Lucas Meneghel Rodrigues
>> Sent: Monday, May 21, 2012 8:57 PM
>> To: autotest@test.kernel.org
>> Subject: [Autotest] [PATCH 2/2] client.kernel_config: Fall back to running
>> config as oldconfig
>>
>> If we couldn't find any of the user provided configuration items when no
>> config file is explicitly provided, fall back to the running kernel config,
>> as it's
>> more likely that we will end up with a functional kernel at the end of the
>> process (defconfig might miss important modules, such as networking).
>
> Hi Lucas and all,
>
> First off, let me say I'm new to autotest both from a user and developer
> perspective so please accept my apologies if the feature I'm proposing below
> is in fact not needed/interesting.
>
> The above change touches on an area I have been looking at the last few days
> - specifically, how users would specify which kernel config to use.
>
> I have been looking at the CLI (autotest-rpc-client) options for kernels when
> creating jobs and I noted that the ability to specify a kernel-config in the
> CLI (via a command-line option) was missing. It appears a kernel config file
> can be explicitly set if the user provides a control file, but comparatively,
> the most you can do directly with command-line options is specify a kernel:
>
> self.parser.add_option('-k', '--kernel', help='A comma separated list'
> ' of kernel versions/URLs/filenames to run the'
> ' job on')
>
> Which in turn would result in a config file entry like this one:
>
> kernel_list = [{'version': '/var/www/kernels/kernel-2012_2_2-2.tar.bz2',
> 'config_file': None}
>
> Am I missing something in thinking the only way to explicitly set the kernel
> config file is for the user to provide the control file?
Good point. Yes, you are correct, control file is the only way right now.
> Would you be opposed to the addition of an option such as this one for the
> CLI:
>
> self.parser.add_option('--kernel-config', help='A comma separated list'
> ' of kernel config files/URLs/filenames to run
> the'
> ' job on. Entries will be paired (in order)
> with values'
> ' provided in the --kernel option')
>
> In short, a user could call:
> autotest-rpc-client job create --kernel "kernel1,kernel2,..." --kernel-config
> "config1,config2,..." -t some_test ...
>
> and the generated kernel_list in the control file would look like this:
> kernel_list = [{'version':'kernel1', 'config_file':'config1'},
> {'version':'kernel2', 'config_file':'config2'},...]
>
> Would this be a useful option? If so I was thinking about working on that
> for my first autotest change.
It looks good to me. I'll be happy to review and accept this new
feature upstream.
Cheers,
--
Lucas
_______________________________________________
Autotest mailing list
Autotest@test.kernel.org
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
