I ran into an issue with the current location of vm_type and connect_uri settings. Having them defined after test variants doesn't allow tests to override them. Especially in the case of connect_uri, this is causing problems with the virsh_migration tests.
However, since there's a need to keep these settings out of the shared base.cfg.sample file, I came up with two possible alternatives (in separate patches). I haven't tested either, but believe they should work. I'd like some feedback on both approaches, which could include "they both suck" :D Thanks! ------------------- Patch 2: It occurred to me that these settings are ultimately tied to the control file being used (i.e. libvirt or kvm). Perhaps, it's easier to just move them to control, and allow the config files and/or command-line to override them as needed. ------------------- Patch 1: Keep the settings in the individual tests-shared.cfg.sample, just move them above all the includes. This allows modification by tests, but also keeps them specialized to the virtualization type. -- Chris Evich, RHCA, RHCE, RHCDS, RHCSS Quality Assurance Engineer e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214 _______________________________________________ Autotest mailing list Autotest@test.kernel.org http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
