On 06/25/2012 12:46 PM, Spear, Raymond (Mission Critical Linux) wrote: > humm... playing with this futher. > > What should this do: > > autotest-rpc-client host list badhost goodhost > > It will fail to find "badhost" but it will find "goodhost". > > One can make the argument that the command failed to find ALL systems and > should exit non-zero. But on the other hand it did find some and so wasn't a > "total failure". Is there the need for a "tri-state" exit?? > 0 - all systems listed found > 1 - no systems listed found > 2 - some systems listed found
I wouldn't say we *need* this tri-state exit code, but we could have it if it's useful. Many apps (rsync comes to my mind) have very rich set of return codes that communicate partial success and other special conditions. > > ray spear > > -----Original Message----- > From: Cleber Rosa [mailto:cr...@redhat.com] > Sent: Friday, June 22, 2012 1:57 PM > To: Spear, Raymond (Mission Critical Linux) > Cc: autotest@test.kernel.org > Subject: Re: [Autotest] Defect? > > On 06/22/2012 04:40 PM, Spear, Raymond (Mission Critical Linux) wrote: >> $ /usr/local/autotest/cli/atest host list xyz; echo $? >> Unknown host(s): >> xyz >> 0 >> >> Should this really return 0. It failed to find the host. I expected it to >> return 1. > Yes, you have a valid point. IMHO > > $ autotest-rpc-client host list > > should return zero even if not hosts are listed, but when asking for a > specific non-existing host like you did, should return non zero. > > Care to send a patch? > > Thanks, > CR. > >> ray spear >> _______________________________________________ >> Autotest mailing list >> Autotest@test.kernel.org >> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest > _______________________________________________ Autotest mailing list Autotest@test.kernel.org http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
