On 06/26/2012 11:34 PM, guyanhua wrote:
>
> Signed-off-by: Gu Yanhua<guyanhua-f...@cn.fujitsu.com>
> ---
> client/virt/subtests.cfg.sample | 26 ++++++++++++++++++++++++++
> 1 files changed, 26 insertions(+), 0 deletions(-)
>
> diff --git a/client/virt/subtests.cfg.sample b/client/virt/subtests.cfg.sample
> index ebfbff5..58cdba3 100644
> --- a/client/virt/subtests.cfg.sample
> +++ b/client/virt/subtests.cfg.sample
> @@ -280,6 +280,32 @@ variants:
> status_error = "yes"
> libvirtd = "off"
>
> + - virsh_freecell:
> + type = virsh_freecell
> + vms = ''
> + variants:
> + - no_option:
> + virsh_freecell_options = ""
> + status_error = "no"
> + libvirtd = "on"
> + - expected_option_all:
> + virsh_freecell_options = "--all"
> + status_error = "no"
> + libvirtd = "on"
> + - expected_option_0:
> + virsh_freecell_options = 0
> + status_error = "no"
> + libvirtd = "on"
> + - unexpected_option_xyz:
> + virsh_freecell_options = "xyz"
> + status_error = "yes"
> + libvirtd = "on"
> + - with_libvirtd_stop:
> + virsh_freecell_options = ""
> + status_error = "yes"
> + libvirtd = "off"
> +
> +
> - module_probe:
> type = module_probe
> # You can specify your own module list, though it is not needed
> usually.
Gu,
It's not critical, what you have is fine. Just to illustrate an example
of how leveraging the Cartesian system can help produce the combination
easier and more flexible (FYI for future additions):
- virsh_freecell:
type = virsh_freecell
vms = ''
variants:
- libvirton:
libvirtd = "on"
- libvirtoff:
libvirtd = "off"
variants:
- expected_options:
status_error = "no"
variants:
- no_option:
virsh_freecell_options = ""
- expected_option_all:
virsh_freecell_options = "--all"
- error_test:
status_error = "yes"
variants:
- expected_option_0:
virsh_freecell_options = 0
- unexpected_option_xyz:
virsh_freecell_options = "xyz"
It's only 1 line shorter than what you have, but it adds three more
tests automatically:
[cevich@cevich shared]$ ./cartesian_config.py foobar
dict 1: virsh_freecell.expected_options.no_option.libvirton
dict 2: virsh_freecell.expected_options.no_option.libvirtoff
dict 3: virsh_freecell.expected_options.expected_option_all.libvirton
dict 4: virsh_freecell.expected_options.expected_option_all.libvirtoff
dict 5: virsh_freecell.error_test.expected_option_0.libvirton
dict 6: virsh_freecell.error_test.expected_option_0.libvirtoff
dict 7: virsh_freecell.error_test.unexpected_option_xyz.libvirton
dict 8: virsh_freecell.error_test.unexpected_option_xyz.libvirtoff
--
Chris Evich, RHCA, RHCE, RHCDS, RHCSS
Quality Assurance Engineer
e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214
_______________________________________________
Autotest mailing list
Autotest@test.kernel.org
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
