On Wed, Jul 11, 2012 at 2:16 PM, Satheesh Rajendran <sathn...@linux.vnet.ibm.com> wrote: > On Wed, 2012-07-11 at 13:49 -0300, Lucas Meneghel Rodrigues wrote: >> On Wed, Jul 11, 2012 at 1:46 PM, Lucas Meneghel Rodrigues >> >> >> >> + - time_manage: >> >> + type = time_manage >> >> + kill_vm = yes >> >> + extra_params +=" -rtc base=utc,driftfix=slew -snapshot" >> >> + host_load_command = stress --vm 1 --vm-bytes 4G --vm-keep >> >> + host_load_kill_command = killall stress >> > >> > ^ Here, this is fine *if* stress is installed in the system, so here >> > it's necessary to at least put a comment saying that this program >> > should be available in $PATH. (moreover, I'm not sure whether this is >> > installable in other types of host, such as Debian, Ubuntu, OpenSUSE. >> > In any case, this is easy enough to fix, I'll test this a bit more and >> > then apply it with the additional comment. > >> Another thing I forgot to comment: Here you seem to imply that stress >> is only memory pressure, rather than also do IO and CPU stress as >> well. Why so? > > Yes, this test needs to be demonstrated in a more > stressed environment, I should have used cpu and io stress too. > Once the patch is available in next, I would change them.
Fair enough, pushed to next, see 45e2bee. Thanks, -- Lucas _______________________________________________ Autotest mailing list Autotest@test.kernel.org http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
