Poornima, Anitha: I was thinking about this, and I was wondering if we couldn't just slightly modify the subtest structure of the Infiniband tests, rather than making this change to html_report.py.
Oh, and Lotus Notes did break up Anitha's and Sohny's addresses, luckily I had Anitha's IMAP address from a previous email she sent me. So, reiterating my stance on this, I'd prefer to look at the Infiniband code, and then modify it to use a different subtest structure, rather than taking this patch, as it brings regression when parsing other tests, such as the virt tests. Cheers, Lucas On Fri, Jul 20, 2012 at 12:12 PM, Poornima Nayak <mpna...@linux.vnet.ibm.com> wrote: > Hi Dror Russo > > Anitha from my team wants to push some of the Infiniband test written by > late Higor to Autotest upstream. While she was testing the code, test > passes but throws error while generating html_report. > So I debugged the code and analyzed where does it fail and found > keyvalue error in parse_result. Patch below fixes the problem but I am > not sure which other tests result generation might fail with my fix. > > Just FYI: Infiniband test has many sub test, like subtest1, subtest2. > Each of the control file invokes run_test with arguments as > job.run_test(url = 'Infiniband/ofed_IBVT_ibv_rc_pingpong', config = > "ofed_community.cfg"). > If you could suggest work around for invoking job_runtest incase of > multiple subtest that also is fine. Else it looks like parse_result > needs a better fix to handle. > > > --- html_report.py_orig 2012-07-14 11:21:11.819706779 -0400 > +++ /usr/local/auto/autotest-autotest-bc43caf/client/tools/html_report.py > 2012-07-14 11:22:24.572706871 -0400 > @@ -1542,7 +1542,7 @@ def parse_result(dirname, line, results_ > stime = int(pair[1]) > results_data[parts[1]] = [stime, [], None] > try: > - parent_test = re.findall(r".*/", parts[1])[0][:-1] > + parent_test = parts[1] > results_data[parent_test][1].append(parts[1]) > except IndexError: > results_data[""][1].append(parts[1]) > > > Regards > Poornima > > _______________________________________________ > Autotest mailing list > Autotest@test.kernel.org > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest -- Lucas _______________________________________________ Autotest mailing list Autotest@test.kernel.org http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
