On 07/25/2012 03:55 AM, Yu Mingfei wrote: > Virsh domname can get vm's name by its running-id or uuid. > These patchs are added to test it. > According Alex's advice, I removed rename's test in this version. > > Yu Mingfei (3): > Add function virsh_domname to libvirt_vm. > Add testcases of virsh domname to subtest.cfg.sample. > Add test of virsh domname to virsh_domname.py. > > client/tests/libvirt/tests/virsh_domname.py | 83 > +++++++++++++++++++++++++++ > client/virt/libvirt_vm.py | 9 +++ > client/virt/subtests.cfg.sample | 44 ++++++++++++++ > 3 files changed, 136 insertions(+), 0 deletions(-) > create mode 100644 client/tests/libvirt/tests/virsh_domname.py > >
This is coming along nicely. I made some comments and suggestions in the test module patch below. They're not all required in my mind, but would add a lot of polish to this test. I agree, making the rename test separate or as an update is a good idea. I'm looking forward to v3, please let us know if you need any help. Thanks. -- Chris Evich, RHCA, RHCE, RHCDS, RHCSS Quality Assurance Engineer e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214 _______________________________________________ Autotest mailing list Autotest@test.kernel.org http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
