Would you accept the attached patch which fixes a crash on Solaris when domain is null?

Padraig

Lennart Poettering wrote:
On Thu, 20.09.07 11:11, Padraig O'Briain ([EMAIL PROTECTED]) wrote:

Hi!

When browse_callback is called in avahi-ui.c is it possible for domain to be null for event AVAHI_BROWSER_FAILURE?

Yes, that's the way the AvahiServiceBrowser works. I wonder if it
would make sense to change that, though...

Lennart

--- /usr/tmp/clean/avahi-0.6.21/avahi-ui/avahi-ui.c	2007-07-31 20:55:06.000000000 +0100
+++ avahi-0.6.21/avahi-ui/avahi-ui.c	2007-09-20 11:13:27.122293000 +0100
@@ -507,7 +507,7 @@
                                                   GTK_MESSAGE_ERROR,
                                                   GTK_BUTTONS_CLOSE,
                                                   "Browsing for service type %s in domain %s failed: %s",
-                                                  type, domain,
+                                                  type, domain ? domain : "null",
                                                   avahi_strerror(avahi_client_errno(d->priv->client)));
             gtk_dialog_run(GTK_DIALOG(m));
             gtk_widget_destroy(m);
_______________________________________________
avahi mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/avahi

Reply via email to