cvs commit: jakarta-avalon-cornerstone/apps/db/src/java/org/apache/avalon/db/basic/handlers/lxsql BasicLXSQLQueryableHandler.java

[hammant]

hammant     01/11/30 02:07:57

  Modified:    apps/db/src/java/org/apache/avalon/db/basic/handlers/lxsql
                        BasicLXSQLQueryableHandler.java
  Log:
  better error reporting
  
  Revision  Changes    Path
  1.4       +12 -3     
jakarta-avalon-cornerstone/apps/db/src/java/org/apache/avalon/db/basic/handlers/lxsql/BasicLXSQLQueryableHandler.java
  
  Index: BasicLXSQLQueryableHandler.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-avalon-cornerstone/apps/db/src/java/org/apache/avalon/db/basic/handlers/lxsql/BasicLXSQLQueryableHandler.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- BasicLXSQLQueryableHandler.java   2001/11/29 14:26:13     1.3
  +++ BasicLXSQLQueryableHandler.java   2001/11/30 10:07:57     1.4
  @@ -34,7 +34,7 @@
    *
    * @author Paul Hammant <a href="mailto:[EMAIL PROTECTED]">[EMAIL 
PROTECTED]</a>
    * @author Gerhard Froehlich <a href="mailto:[EMAIL PROTECTED]">[EMAIL 
PROTECTED]</a>
  - * @version $Revision: 1.3 $
  + * @version $Revision: 1.4 $
    */
   public abstract class BasicLXSQLQueryableHandler extends BasicLXSQLHandler {
   
  @@ -83,8 +83,17 @@
   
   
       protected Column createColumn(Node columnNode, int ix) throws 
ActionException {
  -        String sqlFieldType = 
columnNode.getAttributes().getNamedItem("type").getNodeValue();
  -        String fieldName = 
columnNode.getAttributes().getNamedItem("name").getNodeValue();
  +        Node nameNode = columnNode.getAttributes().getNamedItem("name");
  +        if (nameNode == null) {
  +            throw new ActionException("'name' not specified for one of the 
columns");
  +        }
  +        String fieldName = nameNode.getNodeValue();
  +        Node typeNode = columnNode.getAttributes().getNamedItem("type");
  +        if (typeNode == null) {
  +            throw new ActionException("'type' for " + fieldName + " column 
not specified");
  +        }
  +        String sqlFieldType = typeNode.getNodeValue();
  +
           Column column = null;
           if (sqlFieldType.equals("varchar")) {
               int maxLength = 
Integer.parseInt(columnNode.getAttributes().getNamedItem("max").getNodeValue());
  
  
  

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>