donaldp 02/05/18 02:05:36
Modified: src/java/org/apache/avalon/phoenix/tools/verifier
Resources.properties SarVerifier.java
Log:
Get verifier to spit out warnings if you are still using Block marker
interface.
Revision Changes Path
1.9 +1 -0
jakarta-avalon-phoenix/src/java/org/apache/avalon/phoenix/tools/verifier/Resources.properties
Index: Resources.properties
===================================================================
RCS file:
/home/cvs/jakarta-avalon-phoenix/src/java/org/apache/avalon/phoenix/tools/verifier/Resources.properties,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- Resources.properties 15 May 2002 12:02:12 -0000 1.8
+++ Resources.properties 18 May 2002 09:05:36 -0000 1.9
@@ -23,3 +23,4 @@
verify-listener-type=Verifying that the specified BlockListeners have valid
types.
verifier.service-isa-lifecycle.error=The Block named "{0}" (implementation
class "{1}"), implements a service "{2}" which extends a Lifecycle interface
"{3}". This violates the expected usage patterns.
+verifier.implements-block.error=The Block named "{0}" (implementation class
"{1}"), implements Block interface. The Block interface has been deprecated and
should no longer be used.
1.14 +12 -3
jakarta-avalon-phoenix/src/java/org/apache/avalon/phoenix/tools/verifier/SarVerifier.java
Index: SarVerifier.java
===================================================================
RCS file:
/home/cvs/jakarta-avalon-phoenix/src/java/org/apache/avalon/phoenix/tools/verifier/SarVerifier.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- SarVerifier.java 15 May 2002 12:02:12 -0000 1.13
+++ SarVerifier.java 18 May 2002 09:05:36 -0000 1.14
@@ -57,7 +57,7 @@
* </ul>
*
* @author <a href="mailto:[EMAIL PROTECTED]">Peter Donald</a>
- * @version $Revision: 1.13 $ $Date: 2002/05/15 12:02:12 $
+ * @version $Revision: 1.14 $ $Date: 2002/05/18 09:05:36 $
*/
public class SarVerifier
extends AbstractLogEnabled
@@ -377,6 +377,16 @@
}
}
+ if( Block.class.isAssignableFrom( clazz ) )
+ {
+ final String message =
+ REZ.getString( "verifier.implements-block.error",
+ block.getName(),
+ block.getClassname() );
+ getLogger().error( message );
+ System.err.println( message );
+ }
+
}
/**
@@ -641,7 +651,7 @@
final ClassLoader classLoader )
throws VerifyException
{
- final Class[] classes = new Class[ services.length + 1 ];
+ final Class[] classes = new Class[ services.length ];
for( int i = 0; i < services.length; i++ )
{
@@ -667,7 +677,6 @@
checkNotFrameworkInterface( name, classname, classes[ i ] );
}
- classes[ services.length ] = Block.class;
return classes;
}
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
