donaldp     02/05/18 17:26:27

  Modified:    src/java/org/apache/avalon/phoenix/components/application
                        BlockListenerSupport.java
  Log:
  Refactored to remove duplication.
  
  Revision  Changes    Path
  1.6       +14 -8     
jakarta-avalon-phoenix/src/java/org/apache/avalon/phoenix/components/application/BlockListenerSupport.java
  
  Index: BlockListenerSupport.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-avalon-phoenix/src/java/org/apache/avalon/phoenix/components/application/BlockListenerSupport.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- BlockListenerSupport.java 19 May 2002 00:25:22 -0000      1.5
  +++ BlockListenerSupport.java 19 May 2002 00:26:27 -0000      1.6
  @@ -30,13 +30,7 @@
        */
       void fireBlockAddedEvent( final BlockEntry entry )
       {
  -        final BlockMetaData metaData = entry.getMetaData();
  -        final Object proxy = entry.getProxy();
  -        final BlockEvent event =
  -            new BlockEvent( metaData.getName(),
  -                            proxy,
  -                            metaData.getBlockInfo() );
  -        blockAdded( event );
  +        blockAdded( createEvent( entry ) );
       }
   
       /**
  @@ -47,12 +41,24 @@
        */
       void fireBlockRemovedEvent( final BlockEntry entry )
       {
  +        blockRemoved( createEvent( entry ) );
  +    }
  +
  +    /**
  +     * Utility method to create an event for a
  +     * specific entry.
  +     *
  +     * @param entry the entry
  +     * @return the new event
  +     */
  +    private BlockEvent createEvent( final BlockEntry entry )
  +    {
           final BlockMetaData metaData = entry.getMetaData();
           final BlockEvent event =
               new BlockEvent( metaData.getName(),
                               entry.getProxy(),
                               metaData.getBlockInfo() );
  -        blockRemoved( event );
  +        return event;
       }
   
       /**
  
  
  

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to