-------- Original Message --------
Subject: Re: cvs commit: jakarta-avalon-logkit/src/java/org/apache/log/output 
DefaultOutputLogTarget.java
ServletOutputLogTarget.java
Date: Tue, 08 May 2001 17:11:11 -0400
From: Berin Loritsch <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
References: <[EMAIL PROTECTED]>

>   RCS file: 
>/home/cvs/jakarta-avalon-logkit/src/java/org/apache/log/output/ServletOutputLogTarget.java,v
>   retrieving revision 1.3
>   retrieving revision 1.4
>   diff -u -r1.3 -r1.4
>   --- ServletOutputLogTarget.java       2001/05/04 08:47:27     1.3
>   +++ ServletOutputLogTarget.java       2001/05/08 20:49:16     1.4
>   @@ -32,7 +32,6 @@
>        {
>            if( null != m_context )
>            {
>   -            //Do we really need to synchronize on this?????????????
>                synchronized( m_context )
>                {
>                    m_context.log( message );
> 

Yes.  The problem is that the Servlet 2.2 Spec does *NOT* guarantee the Context logger
to be threadsafe.  So we must guarantee it ourselves.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to