issue #1:
all but jakarta-avalon don't work, because
AVLAON_TOOLS (or TOOLS?) is set to a none-existent
dir. The solution is of course simple (cp of
tools dir from jakarta-avalon), but it'd be nice
to have a little more intelligence, where the
build.sh/bat file looks whether
../jakarta-avalon/tools exists and uses the files
from there.
Or not?
issue #2:
phoenix doesn't compile. Log:
----------------------------------------------------------------------------
F:\cvs\avalon\jakarta-avalon-phoenix>build
------------
Build System
------------
Buildfile: build.xml
compile:
Compiling 15 source files to
F:\cvs\avalon\jakarta-avalon-phoenix\build\classes
F:\cvs\avalon\jakarta-avalon-phoenix\src\java\org\apache\avalon\phoenix\comp
onen
ts\phases\StartupPhase.java:176: cannot resolve symbol
symbol : variable configuration
location: class org.apache.avalon.phoenix.components.phases.StartupPhase
((Configurable)object).configure( configuration );
^
1 error
BUILD FAILED
Compile failed, messages should have been provided.
----------------------------------------------------------------------------
code snippet:
----------------------------------------------------------------------------
//Configuring stage
if( object instanceof Configurable )
{
tLogger().debug( REZ.getString( "startup.notice.config.pre" ) );
try
{
final Configuration configuration =
m_repository.getConfiguration( m_appName, name );
}
catch( final ConfigurationException ce )
{
// missing configuration (probably).
final String message =
EZ.getString( "startup.error.block.noconfiguration", name );
throw new ConfigurationException( message, ce );
}
((Configurable)object).configure( configuration );
tLogger().debug( REZ.getString( "startup.notice.config.success" ) );
----------------------------------------------------------------------------
seems like this should be:
----------------------------------------------------------------------------
//Configuring stage
if( object instanceof Configurable )
{
tLogger().debug( REZ.getString( "startup.notice.config.pre" ) );
try
{
final Configuration configuration =
m_repository.getConfiguration( m_appName, name );
((Configurable)object).configure( configuration );
}
catch( final ConfigurationException ce )
{
// missing configuration (probably).
final String message =
EZ.getString( "startup.error.block.noconfiguration", name );
throw new ConfigurationException( message, ce );
}
tLogger().debug( REZ.getString( "startup.notice.config.success" ) );
----------------------------------------------------------------------------
amiright? (or
not-make-it-final-and-initialize-to-null-outside-the-try-block)
nice reworking BTW, pete! Sometimes, removing indirection just makes things
look sooooo much easier =) Are you still working on stuff or can I hack
phoenix CVS?
Also like the fully automatic download of the servletapi by logkit ;)
ant is cool ;) Oh, and me like allavalonbuild.xml
cheers,
- Leo
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
