hammant 01/11/13 18:47:22
Modified: apps/db/src/java/org/apache/avalon/db/basic/actions
BasicCreateQueryable.java BasicInsert.java
Log:
updated type handling
Revision Changes Path
1.6 +4 -6
jakarta-avalon-cornerstone/apps/db/src/java/org/apache/avalon/db/basic/actions/BasicCreateQueryable.java
Index: BasicCreateQueryable.java
===================================================================
RCS file:
/home/cvs/jakarta-avalon-cornerstone/apps/db/src/java/org/apache/avalon/db/basic/actions/BasicCreateQueryable.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- BasicCreateQueryable.java 2001/11/14 02:40:29 1.5
+++ BasicCreateQueryable.java 2001/11/14 02:47:22 1.6
@@ -37,13 +37,13 @@
*
*
* @author Paul Hammant <a
href="mailto:[EMAIL PROTECTED]";>[EMAIL PROTECTED]</a>
- * @version $Revision: 1.5 $
+ * @version $Revision: 1.6 $
*/
public abstract class BasicCreateQueryable extends AbstractAction implements
CreateTable {
/**
- * Method execute
+ * Method getColumns
*
*
*/
@@ -60,13 +60,11 @@
if (subColumnsNodes.item(x).getNodeName().equals("column")) {
columns.add(createColumn(subColumnsNodes.item(x)));
} else {
- // TODO There should be no other element types inside
<columns>
+ throw new ActionException("Only 'column' allowed as a node
under 'columns' node");
}
-
}
-
} else {
- //TODO Only <columns> is supported in <create-table> so far
+ throw new ActionException("Only 'columns' allowed as a node under
'create-table' node");
}
}
1.7 +2 -1
jakarta-avalon-cornerstone/apps/db/src/java/org/apache/avalon/db/basic/actions/BasicInsert.java
Index: BasicInsert.java
===================================================================
RCS file:
/home/cvs/jakarta-avalon-cornerstone/apps/db/src/java/org/apache/avalon/db/basic/actions/BasicInsert.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- BasicInsert.java 2001/11/13 16:04:34 1.6
+++ BasicInsert.java 2001/11/14 02:47:22 1.7
@@ -99,8 +99,9 @@
String colName = rowNode.getAttribute("col");
String valueStr = rowNode.getFirstChild().getNodeValue();
int ix = mTable.getColumnIndex(colName);
- // TODO perhaps coluns could know their own index?
+ // TODO perhaps columns could know their own index?
Column col = mTable.getColumn(colName);
+ col.test(valueStr);
values[ix] = col.convertFromString(valueStr);
}
}
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
