Bug found in Excalibur-4.0, org.apache.avalon.excalibur.datasource.JdbcConnection class

[Annette Doyle]

In the constructor of class
org.apache.avalon.excalibur.datasource.JdbcConnection, there is a bug in the
following if statement:

        if (null != keepAlive && "".equals(keepAlive.trim()))
//should be !("".equals(keepAlive.trim()))
        {
            try
            {
                m_test_statement = prepareStatement(keepAlive);
            }
            catch ( final SQLException se )
            {
                m_test_statement = null;
                m_test_exception = se;
            }
        }
        else
        {
            m_test_statement = null;
            m_test_exception = null;
        }

The condition in the if statement should be the following:

if (null != keepAlive && !("".equals(keepAlive.trim())))

There should be a boolean NOT ! operator before "".equals(keepAlive.trim()).

Annette Doyle



--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>